Read/write refs on this #125
Conversation
|
👍 If it works, it's good with me! |
|
It looks good to me too. Maybe we could type check that one is not overwriting a life cycle method. |
Using the `ref` prop writes the ref to the `this.refs` object. However, setting a ref with a callback is not allowed to write to the frozen `this.refs`. It writes directly to `this` instead.
|
Thanks for taking a look! It turns out that react will still write a ref to @coot I think doing a check is a good call. Are you suggesting to check directly in the JS? |
|
I was suggesting to do that on the type level. |
|
Gotcha. I am wondering if maybe releasing this change as a patch release could be done first. Then we can introduce the type change as a separate PR as a breaking change? |
|
Yes, I think that's fine. |
Fixes #123
Proposal to resolve the issue due to the refs object being frozen.
I am open to other ideas on this. Any feedback is most welcome!
@paf31 @coot